Implement exponential backoff with jitter for reconnections - #3
Open
graygnuorg wants to merge 2 commits into
Open
Implement exponential backoff with jitter for reconnections#3graygnuorg wants to merge 2 commits into
graygnuorg wants to merge 2 commits into
Conversation
This avoids eating up system resources if the XMPP server is down and limits initial impact on it when it gets up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the XMPP server goes down, nagibot enters an endless loop trying to reconnect, failing and retrying again. This needlessly consumes the machine's resources and generates an enormous amount of logs. This patch implements the exponential backoff with jitter strategy to control the interval between two insuccessful reconnection attempts. This allows nagibot to reconnect in time without producing extra load and mitigates eventual impact on the XMPP server when many nagibots are trying to connect to it.
For the sake of readability the request is composed of two distinct commits: the first one replaces the "goto" loop with an
"until" loop, and the second one contains the main changes.